Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16284 )
Change subject: [benchmarks] added a few 'perf stat' metrics ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16284/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16284/3//COMMIT_MSG@11 PS3, Line 11: * instructions per cycle : * CPU utilization : * branch misses > >IPC usually varies less than 2% run to run; the variation of other two are Right -- the application-level metrics are specifically designed to pin-point particular performance issues. The system-wide performance monitoring counters are to cover how effective the generated code is, whether it's CPU or memory-bound, etc. http://gerrit.cloudera.org:8080/#/c/16284/3/src/kudu/scripts/benchmarks.sh File src/kudu/scripts/benchmarks.sh: http://gerrit.cloudera.org:8080/#/c/16284/3/src/kudu/scripts/benchmarks.sh@338 PS3, Line 338: # able to run under 'perf? > nit: spacing? Done http://gerrit.cloudera.org:8080/#/c/16284/3/src/kudu/scripts/benchmarks.sh@573 PS3, Line 573: # parse scan timings for scans and inserts with MRS only > Ah indeed. I should have made that connection to this parsing. I updated the description of this patch to explicitly mention those. -- To view, visit http://gerrit.cloudera.org:8080/16284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib742ffbaabca96c2ac455481313348da2133ff6e Gerrit-Change-Number: 16284 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 10 Aug 2020 23:43:24 +0000 Gerrit-HasComments: Yes
