Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16378 )
Change subject: tablet: replace MVCC "commit" with "apply" ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/16378/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16378/1//COMMIT_MSG@7 PS1, Line 7: MVCC "commit" > Do you plan to update docs like $KUDU_ROOT/docs/transaction_semantics.adoc Yeah, definitely once more of the transaction work becomes usable. There isn't much in that doc related to this change in terminology, or are you suggesting I add some? http://gerrit.cloudera.org:8080/#/c/16378/1/src/kudu/tablet/mvcc.cc File src/kudu/tablet/mvcc.cc: http://gerrit.cloudera.org:8080/#/c/16378/1/src/kudu/tablet/mvcc.cc@39 PS1, Line 39: txn > While you are here, maybe replace txn --> op here for this flag as well? I Done http://gerrit.cloudera.org:8080/#/c/16378/1/src/kudu/tablet/mvcc.cc@73 PS1, Line 73: txn > op ? Done http://gerrit.cloudera.org:8080/#/c/16378/1/src/kudu/tablet/ops/op.h File src/kudu/tablet/ops/op.h: http://gerrit.cloudera.org:8080/#/c/16378/1/src/kudu/tablet/ops/op.h@131 PS1, Line 131: commit message > Raft commit message ? Done http://gerrit.cloudera.org:8080/#/c/16378/1/src/kudu/tablet/ops/participant_op.cc File src/kudu/tablet/ops/participant_op.cc: http://gerrit.cloudera.org:8080/#/c/16378/1/src/kudu/tablet/ops/participant_op.cc@185 PS1, Line 185: committed > applied Done -- To view, visit http://gerrit.cloudera.org:8080/16378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4da2ed45daf1d4bf74ea12c2616a4a550c45fc65 Gerrit-Change-Number: 16378 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 28 Aug 2020 06:27:58 +0000 Gerrit-HasComments: Yes
