Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16378 )
Change subject: tablet: replace MVCC "commit" with "apply" ...................................................................... tablet: replace MVCC "commit" with "apply" As multi-op transaction work progresses, the distinction between "apply" and "commit" will widen, so let's clarify the terminology up front. This is a first step, replacing the MvccManager's "commit" terminology with "apply" terminology. As far as MVCC is concerned, there is no concept of "transaction commit" today, only "Raft committed and applied". Thus, all current usages of MVCC's "commit" have been replaced with "apply". This is somewhat heavy-handed, but correct for now, and may be adjusted as needed as "transaction commit" becomes more clearly specified. For example: - committed --> applied - commit --> finish applying - uncommitted --> nonapplied As "Raft commit" and "commit messages" (logical Raft committing entails updating a commit index on Raft leaders) differ from MVCC's usage of commit (i.e. an op is "MVCC committed" once it physically applies the op to underlying stores), I left such terminology alone. Change-Id: I4da2ed45daf1d4bf74ea12c2616a4a550c45fc65 Reviewed-on: http://gerrit.cloudera.org:8080/16378 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/integration-tests/raft_consensus_election-itest.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/compaction.h M src/kudu/tablet/delta_relevancy.h M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/diff_scan-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/local_tablet_writer.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/memrowset.cc M src/kudu/tablet/mvcc-test.cc M src/kudu/tablet/mvcc.cc M src/kudu/tablet/mvcc.h M src/kudu/tablet/ops/alter_schema_op.cc M src/kudu/tablet/ops/op.h M src/kudu/tablet/ops/op_driver.cc M src/kudu/tablet/ops/participant_op.cc M src/kudu/tablet/ops/write_op.cc M src/kudu/tablet/ops/write_op.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tserver/tablet_service.cc 26 files changed, 445 insertions(+), 444 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/16378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4da2ed45daf1d4bf74ea12c2616a4a550c45fc65 Gerrit-Change-Number: 16378 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
