Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16387
Change subject: tablet: refactor delta iteration code ...................................................................... tablet: refactor delta iteration code While examining existing delta iteration code, I noticed significant similarities between the DeltaFileIterator and DMSIterator. After shuffling some code around, some clear abstractions formed, and so this patch introduces the DeltaStoreIterator that, along with the existing DeltaPreparer, comprises implementations of the existing DeltaIterator. The DeltaStoreIterator loads batches of deltas from the underlying delta stores, to be passed to the DeltaPreparer and used as needed. All existing implementations of DeltaIterators follow this pattern and are updated to use the new abstraction as such. I expect that in the future, this will also facilitate implementing different styles of delta iteration, e.g. iterating over a delta store as if all deltas were committed at a single timestamp, or applying the deltas of several delta stores that overlap in time, etc. Change-Id: Iafc9cffa51964f81bc01fd8fcf1b6a79770a7838 --- M src/kudu/tablet/delta_applier.cc M src/kudu/tablet/delta_iterator_merger.cc M src/kudu/tablet/delta_iterator_merger.h M src/kudu/tablet/delta_store.cc M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltafile.cc M src/kudu/tablet/deltafile.h M src/kudu/tablet/deltamemstore.cc M src/kudu/tablet/deltamemstore.h 9 files changed, 557 insertions(+), 468 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/16387/1 -- To view, visit http://gerrit.cloudera.org:8080/16387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iafc9cffa51964f81bc01fd8fcf1b6a79770a7838 Gerrit-Change-Number: 16387 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]>
