Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16343 )
Change subject: KUDU-1587 part 2: reject write ops if apply queue is overloaded ...................................................................... KUDU-1587 part 2: reject write ops if apply queue is overloaded This patch implements control admission for write requests in tablet servers based on the load status of their apply queue. With this change, the recently introduced OpApplyQueueTest.ApplyQueueBackpressure scenario successfully passes. If the queue times of the tasks in the apply queue become higher than the specified threshold, the apply queue enters overloaded state. When the queue is overloaded, the tablet server rejects incoming write requests with some probability. The longer the queue stays overloaded, the greater the probability of rejections. The apply queue exits the overloaded state when queue times drop below the specified threshold. This new behavior is not yet enabled by default, keeping the legacy behavior of unbounded/uncontrolled queue times as is. To enable it, set --tablet_apply_pool_overload_threshold_ms to something greater than 0 (e.g., 500). Change-Id: I6d7688d6fa832e606b8efc4549568fa52dfa1931 Reviewed-on: http://gerrit.cloudera.org:8080/16343 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/integration-tests/same_tablet_concurrent_writes-itest.cc M src/kudu/kserver/kserver.cc M src/kudu/kserver/kserver.h A src/kudu/kserver/kserver_options.h M src/kudu/master/master_options.h M src/kudu/tablet/tablet_replica.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_server_options.cc M src/kudu/tserver/tablet_server_options.h M src/kudu/tserver/tablet_server_runner.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h 13 files changed, 352 insertions(+), 107 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6d7688d6fa832e606b8efc4549568fa52dfa1931 Gerrit-Change-Number: 16343 Gerrit-PatchSet: 12 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]>
