Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16340 )
Change subject: [master] KUDU-3182 Allow single master to specify --master_addresses ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/16340/4/src/kudu/master/sys_catalog.h File src/kudu/master/sys_catalog.h: http://gerrit.cloudera.org:8080/#/c/16340/4/src/kudu/master/sys_catalog.h@360 PS4, Line 360: // For a single master config, verifies the on-disk Raft config and populates the : // 'last_known_addr' in the on-disk Raft config, if master address is sp > nit: Could you make it more obvious that this may update on-disk state? Done http://gerrit.cloudera.org:8080/#/c/16340/4/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/16340/4/src/kudu/master/sys_catalog.cc@198 PS4, Line 198: ftConfigPB config = cmeta->CommittedCon > nit: it's a little misleading to have this be a const ref. Maybe pass a raw Done http://gerrit.cloudera.org:8080/#/c/16340/4/src/kudu/master/sys_catalog.cc@200 PS4, Line 200: masters specified in the on-disk Raft config, so log a warning instead of a strict check. : // No further validations or populating 'last_kno > nit: "Current" will change as the multi-master migration implementation con Done -- To view, visit http://gerrit.cloudera.org:8080/16340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fe1bcd217d68f66db72c321397d596cba4224be Gerrit-Change-Number: 16340 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 02 Sep 2020 21:17:22 +0000 Gerrit-HasComments: Yes
