Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16340 )
Change subject: [master] KUDU-3182 Allow single master to specify --master_addresses ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/16340/5/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/16340/5/src/kudu/master/sys_catalog.cc@292 PS5, Line 292: } else { : RETURN_NOT_OK(VerifyAndPopulateSingleMasterConfig(cmeta.get())); readability nit: could you move this to be the first clause under 'if ()' ? I think it would help in code readability a bit. http://gerrit.cloudera.org:8080/#/c/16340/5/src/kudu/util/net/net_util.h File src/kudu/util/net/net_util.h: http://gerrit.cloudera.org:8080/#/c/16340/5/src/kudu/util/net/net_util.h@107 PS5, Line 107: bool operator!=(const HostPort& hp1, const HostPort& hp2); nit: I guess the definition of operator!= might be in-lined; or the definition of this method is put into the .cc file for some specific reason? -- To view, visit http://gerrit.cloudera.org:8080/16340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fe1bcd217d68f66db72c321397d596cba4224be Gerrit-Change-Number: 16340 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 02 Sep 2020 22:52:50 +0000 Gerrit-HasComments: Yes
