Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16403 )
Change subject: KUDU-2574: Add a unique cluster ID ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/16403/6/src/kudu/integration-tests/master_failover-itest.cc File src/kudu/integration-tests/master_failover-itest.cc: http://gerrit.cloudera.org:8080/#/c/16403/6/src/kudu/integration-tests/master_failover-itest.cc@513 PS6, Line 513: // Validate the cluster ID of the new leader matches. : int new_leader_idx; : ASSERT_OK(cluster_->GetLeaderMasterIndex(&new_leader_idx)); : ASSERT_NE(leader_idx, new_leader_idx); > You could stick this in ASSERT_EVENTUALLY(), since shutting down the server I just removed it and left the old master shutdown per Alexey's suggestion. -- To view, visit http://gerrit.cloudera.org:8080/16403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4df1d3f7d100336f52563f3008cacf6d9e328fae Gerrit-Change-Number: 16403 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 03 Sep 2020 17:27:15 +0000 Gerrit-HasComments: Yes
