Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16403 )
Change subject: KUDU-2574: Add a unique cluster ID ...................................................................... Patch Set 5: Code-Review+1 (2 comments) IWYU is not happy, but otherwise LGTM. >>> Fixing #includes in >>> '/home/jenkins-slave/workspace/kudu-master/2/src/kudu/integration-tests/master_failover-itest.cc' @@ -36,7 +36,7 @@ #include "kudu/gutil/strings/strip.h" // IWYU pragma: keep #include "kudu/gutil/strings/substitute.h" #include "kudu/integration-tests/cluster_itest_util.h" -#include "kudu/master/master.proxy.h" +#include "kudu/master/master.pb.h" #include "kudu/master/sys_catalog.h" // IWYU pragma: keep #include "kudu/mini-cluster/external_mini_cluster.h" #include "kudu/util/metrics.h" IWYU would have edited 1 files on your behalf. http://gerrit.cloudera.org:8080/#/c/16403/4/src/kudu/common/wire_protocol.proto File src/kudu/common/wire_protocol.proto: http://gerrit.cloudera.org:8080/#/c/16403/4/src/kudu/common/wire_protocol.proto@124 PS4, Line 124: optional string cluster_id = 5; > Not without a good amount of change because ListMasters returns a list of S SGTM. Thank you for the clarification. http://gerrit.cloudera.org:8080/#/c/16403/5/src/kudu/integration-tests/master_failover-itest.cc File src/kudu/integration-tests/master_failover-itest.cc: http://gerrit.cloudera.org:8080/#/c/16403/5/src/kudu/integration-tests/master_failover-itest.cc@515 PS5, Line 515: ASSERT_OK(cluster_->GetLeaderMasterIndex(&new_leader_idx)); : ASSERT_NE(leader_idx, new_leader_idx); Is it possible that the newly elected master will be of the same index again? Maybe, just keep the former leader shut down? -- To view, visit http://gerrit.cloudera.org:8080/16403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4df1d3f7d100336f52563f3008cacf6d9e328fae Gerrit-Change-Number: 16403 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 03 Sep 2020 17:13:44 +0000 Gerrit-HasComments: Yes
