Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16400 )
Change subject: KUDU-3012: Add a Log Throttler ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/16400/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16400/5//COMMIT_MSG@7 PS5, Line 7: KUDU-3012: Add a Log Throttler As an alternative approach, could it be enough to log that particular warning message just once? http://gerrit.cloudera.org:8080/#/c/16400/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/16400/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@554 PS5, Line 554: 60L In this particular case, would it be enough to log just once regardless of how long a closed session being pounded with apply() calls? Then there is no need to have log throttler at all. -- To view, visit http://gerrit.cloudera.org:8080/16400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2089b6fc905a5b54d664b7200060cabb965f40f Gerrit-Change-Number: 16400 Gerrit-PatchSet: 5 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 09 Sep 2020 22:34:31 +0000 Gerrit-HasComments: Yes
