Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16400 )
Change subject: KUDU-3012: Add a Log Throttler ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/16400/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16400/4//COMMIT_MSG@11 PS4, Line 11: gardless > throttles regardless of message Done http://gerrit.cloudera.org:8080/#/c/16400/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16400/5//COMMIT_MSG@7 PS5, Line 7: KUDU-3012: Add a Log Throttler > As an alternative approach, could it be enough to log that particular warni decided to go with a log throttler, more flexible if we want to throttler other messages in the future http://gerrit.cloudera.org:8080/#/c/16400/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/16400/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@118 PS4, Line 118: > decided to keep it as is for now, if a strong case for making it static is Done http://gerrit.cloudera.org:8080/#/c/16400/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@554 PS4, Line 554: > decided once per minute is fine Done http://gerrit.cloudera.org:8080/#/c/16400/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/16400/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@554 PS5, Line 554: > After discussing this offline, it's clear that either 60 second interval, 1 Ultimately decided to log once every 60 seconds, thanks everyone for all your input http://gerrit.cloudera.org:8080/#/c/16400/5/java/kudu-client/src/main/java/org/apache/kudu/util/LogThrottler.java File java/kudu-client/src/main/java/org/apache/kudu/util/LogThrottler.java: http://gerrit.cloudera.org:8080/#/c/16400/5/java/kudu-client/src/main/java/org/apache/kudu/util/LogThrottler.java@34 PS5, Line 34: TODO(mreddy): Efficiently support variable arguments by explicitly checking for arguments length : * in logging functions and call corresponding function rather than calling function with varargs : * every time. This will avoid the hidden cost of creating an Object[] before invoking the method. > The only concern with variadic arguments is performance, right? that would provide a more flexible implementation, will add functions with 0, 1, 2, or more variable arguments, more details in the Logger interface -- To view, visit http://gerrit.cloudera.org:8080/16400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2089b6fc905a5b54d664b7200060cabb965f40f Gerrit-Change-Number: 16400 Gerrit-PatchSet: 6 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 10 Sep 2020 22:57:18 +0000 Gerrit-HasComments: Yes
