Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16458 )
Change subject: [test] Fix Unix socket tests on macOS ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16458/1/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/16458/1/src/kudu/rpc/rpc-test.cc@65 PS1, Line 65: #include "kudu/util/oid_generator.h" Looks like this needs to be #ifdef 'ed as well for MacOS. http://gerrit.cloudera.org:8080/#/c/16458/1/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/16458/1/src/kudu/util/net/socket-test.cc@34 PS1, Line 34: #include <kudu/util/oid_generator.h> Double quotes instead of <> brackets. -- To view, visit http://gerrit.cloudera.org:8080/16458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I434e92e86fb87d1085c35b5d707d1238295192fb Gerrit-Change-Number: 16458 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 16 Sep 2020 14:59:28 +0000 Gerrit-HasComments: Yes
