Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16458 )
Change subject: [test] Fix Unix socket tests on macOS ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16458/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16458/1//COMMIT_MSG@9 PS1, Line 9: macOS does not support abstract namespaces for sockets. > While you are on it, maybe it's worth updating the code to make it as porta You mean we should just default to using a standard path in sever_base.cc instead of only on macOS? -- To view, visit http://gerrit.cloudera.org:8080/16458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I434e92e86fb87d1085c35b5d707d1238295192fb Gerrit-Change-Number: 16458 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 16 Sep 2020 15:48:16 +0000 Gerrit-HasComments: Yes
