Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16495
to look at the new patch set (#2).
Change subject: WIP KUDU-2612 p2 (b): add transaction status retrieval
......................................................................
WIP KUDU-2612 p2 (b): add transaction status retrieval
After offline discussions with Andrew, it became clear that TxnManager
should provide an asynchronous interface to commit a transaction, i.e.
something similar to CreateTable()/IsCreateTableDone(). To implement
that, the TxnManager needs to check for the status of the transaction
after initiating the commit phase by issuing corresponding call
to TxnStatusManager (that's implemented as CoordinateTransaction() RPC
to TabletServerAdminService with BEGIN_COMMIT_TXN operation type).
This patch introduces the required server-side piece to retrieve the
information on a transaction status from the TxnStatusManager. I'm
planning to introduce corresponding bindings via the TxnSystemClient
in a separate changelist.
This is a follow-up to efd8c4f165460b7fa337b8ebd1856b10bc274311.
WIP:
* I'd like to get some feedback on this approach:
-- Is it OK to have a method to fetch transaction status
as another operation type for the TxnStatusManager?
-- Is it OK to use PB structures for the status of
a transaction or we want to wrap that into something else?
-- Anything else?
Change-Id: I45f099d943f2b7955d6d561a1cb883343c7b79a4
---
M src/kudu/tablet/txn_coordinator.h
M src/kudu/transactions/CMakeLists.txt
M src/kudu/transactions/txn_status_manager-test.cc
M src/kudu/transactions/txn_status_manager.cc
M src/kudu/transactions/txn_status_manager.h
M src/kudu/transactions/txn_status_tablet.h
M src/kudu/tserver/CMakeLists.txt
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver_admin.proto
9 files changed, 165 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/16495/2
--
To view, visit http://gerrit.cloudera.org:8080/16495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I45f099d943f2b7955d6d561a1cb883343c7b79a4
Gerrit-Change-Number: 16495
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
