Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16495 )
Change subject: WIP KUDU-2612 p2 (b): add transaction status retrieval ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/16495/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16495/2//COMMIT_MSG@26 PS2, Line 26: -- Is it OK to have a method to fetch transaction status I was on the fence about exposing as a CoordinatorOp because it seems like there is a difference in concerns -- all other ops may mutate the transaction state, while this new op doesn't. That said, beyond that I can't articulate a good reason why not reuse what we have. I'm fine keeping it as is. http://gerrit.cloudera.org:8080/#/c/16495/2//COMMIT_MSG@28 PS2, Line 28: -- Is it OK to use PB structures for the status of I think it's fine to expose these as pb given it is internal API. http://gerrit.cloudera.org:8080/#/c/16495/2/src/kudu/transactions/txn_status_manager-test.cc File src/kudu/transactions/txn_status_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/16495/2/src/kudu/transactions/txn_status_manager-test.cc@445 PS2, Line 445: // Supplying not-yet-used transaction idenfier. Nit: ID or identifier, same below http://gerrit.cloudera.org:8080/#/c/16495/2/src/kudu/tserver/tserver_admin.proto File src/kudu/tserver/tserver_admin.proto: http://gerrit.cloudera.org:8080/#/c/16495/2/src/kudu/tserver/tserver_admin.proto@55 PS2, Line 55: // TODO(aserbin): does it make sense to populate this with the current status Good thought. I can imagine this being useful in the future for debugging cases where we have returned an error -- To view, visit http://gerrit.cloudera.org:8080/16495 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45f099d943f2b7955d6d561a1cb883343c7b79a4 Gerrit-Change-Number: 16495 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Sep 2020 19:09:24 +0000 Gerrit-HasComments: Yes
