Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16494 )
Change subject: KUDU-3192: [hms] Leverage the cluster ID in HMS sync ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/16494/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/16494/4/src/kudu/master/catalog_manager.cc@5511 PS4, Line 5511: // names when normalized. : ignore_result(hms::HmsCatalog::NormalizeTableName(&normalized_table_name)); : } : > Looking around for how this can be thread-safe, I think the answer is that This actually manifested in some TSAN failures. I moved the cluster ID back into the CatalogManager and exposed it via `GetClusterId` which calls `CatalogManager::GetClusterId`. -- To view, visit http://gerrit.cloudera.org:8080/16494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I865b418a3cc4e11c889cc4757cd940831c43af17 Gerrit-Change-Number: 16494 Gerrit-PatchSet: 5 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 30 Sep 2020 21:23:29 +0000 Gerrit-HasComments: Yes
