Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16494 )
Change subject: KUDU-3192: [hms] Leverage the cluster ID in HMS sync ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/16494/8/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/16494/8/src/kudu/master/catalog_manager.cc@4608 PS8, Line 4608: leader_lock_.AssertAcquiredForReading(); Doesn't this mean that only leaders can return the cluster ID? If so, what's the point of PrepareFollowerClusterId()? Alternatively we could have a separate lock for it, or maybe re-use lock_ assuming that's safe. -- To view, visit http://gerrit.cloudera.org:8080/16494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I865b418a3cc4e11c889cc4757cd940831c43af17 Gerrit-Change-Number: 16494 Gerrit-PatchSet: 8 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 01 Oct 2020 18:01:09 +0000 Gerrit-HasComments: Yes
