Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16494 )
Change subject: KUDU-3192: [hms] Leverage the cluster ID in HMS sync ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/hms/hms_client-test.cc File src/kudu/hms/hms_client-test.cc: http://gerrit.cloudera.org:8080/#/c/16494/1/src/kudu/hms/hms_client-test.cc@169 PS1, Line 169: ASSERT_TRUE(CreateTable(&client, database_name, table_name, : table_id, cluster_id).IsAlreadyPresent()); > CreateTable in the HMS client is HMS specific. Only the table_name matters Thank you for the clarification. Just wanted to make sure my understanding is correct w.r.t. table name being the primary identifier for a table in HMS. Does it mean it's not possible to have two tables with same name in different clusters managed by the same HMS instance? http://gerrit.cloudera.org:8080/#/c/16494/9/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/16494/9/src/kudu/master/catalog_manager.cc@1045 PS9, Line 1045: std::lock_guard<simple_spinlock> l(cluster_id_lock_); I'm not sure I understand why this lock is necessary here. As I can see, 'cluster_id' is an output parameter and should not be shared among multiple threads calling this method, and 'entry' is on stack of every thread that would call this method, right? -- To view, visit http://gerrit.cloudera.org:8080/16494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I865b418a3cc4e11c889cc4757cd940831c43af17 Gerrit-Change-Number: 16494 Gerrit-PatchSet: 9 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 01 Oct 2020 22:03:20 +0000 Gerrit-HasComments: Yes
