Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16539 )
Change subject: [tests] fix flake in TestTabletServerProxyCallErrors ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16539/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/16539/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc@1075 PS1, Line 1075: // Wait for the tablet to be in RUNNING state. : const auto deadline = MonoTime::Now() + kTimeout; : bool is_tablet_running = false; : do { : if (r->CheckRunning().ok()) { : is_tablet_running = true; : break; : } : SleepFor(MonoDelta::FromMilliseconds(10)); : } while (MonoTime::Now() < deadline); : if (!is_tablet_running) { : Status::TimedOut("timed out waiting for txn status tablet running"); : } nit: can we use r->WaitUntilConsensusRunning() instead? -- To view, visit http://gerrit.cloudera.org:8080/16539 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64b9f1eeb6bacf684a15ef84cddacadb43ac43fe Gerrit-Change-Number: 16539 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 03 Oct 2020 01:07:17 +0000 Gerrit-HasComments: Yes
