Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16539 )
Change subject: [tests] fix flake in TestTabletServerProxyCallErrors ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16539/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/16539/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc@1075 PS1, Line 1075: // Wait for the tablet to be in RUNNING state and its consensus running too. : RETURN_NOT_OK(r->WaitUntilConsensusRunning(kTimeout)); : return r->consensus()->WaitUntilLeaderForTests(kTimeout); : } : : // Creates a transaction status tablet at the given tablet server. : Status CreateTxnStatusTablet(MiniTabletServer* ts) { : return CreateTablet(ts, kTxnStatusTabletId, /*is_txn_status_tablet*/true); : } : : static Status StartTransactions(const ParticipantIdsByTxnId& txns, TxnCoordinator* coordinator) { : TabletServerErrorPB ts_error; : f > nit: can we use r->WaitUntilConsensusRunning() instead? Good point -- it seems we can. For some reason, I didn't see that WaitUntilConsensusRunning() existed. -- To view, visit http://gerrit.cloudera.org:8080/16539 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64b9f1eeb6bacf684a15ef84cddacadb43ac43fe Gerrit-Change-Number: 16539 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 03 Oct 2020 02:45:17 +0000 Gerrit-HasComments: Yes
