Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16631 )
Change subject: Fix order of clearing and printing openssl error ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16631/1//COMMIT_MSG Commit Message: PS1: > +1 I tried to add a test, but I have no good way to trigger this consistently, it seems to have been triggered by a thread safety problem in SafeLogic's CryptoComply Server OpenSSL 1.0.2v-fips. I tried creating a malformed PEM file, but then the error returned on Cert::FromString() instead of TlsContext::VerifyCertChainUnlocked(). http://gerrit.cloudera.org:8080/#/c/16631/1/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: http://gerrit.cloudera.org:8080/#/c/16631/1/src/kudu/security/tls_context.cc@248 PS1, Line 248: int err = X509_STORE_CTX_get_error(store_ctx.get()); > Maybe, it's also worth outputting the collected error information along wit Done -- To view, visit http://gerrit.cloudera.org:8080/16631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f78bdedce7a976a6e8117bb8683032dd917c626 Gerrit-Change-Number: 16631 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 23 Oct 2020 12:27:28 +0000 Gerrit-HasComments: Yes
