Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16631 )
Change subject: Fix order of clearing and printing openssl error ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/16631/3/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: http://gerrit.cloudera.org:8080/#/c/16631/3/src/kudu/security/tls_context.cc@249 PS3, Line 249: > Is this still necessary to add ERR_clear_error() after calling GetOpenSSLEr Nope, you're right. I wasn't aware that GetOpenSSLErrors() also clears the errors. -- To view, visit http://gerrit.cloudera.org:8080/16631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f78bdedce7a976a6e8117bb8683032dd917c626 Gerrit-Change-Number: 16631 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 23 Oct 2020 16:27:01 +0000 Gerrit-HasComments: Yes
