Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16655
to look at the new patch set (#2).
Change subject: [tserver] validator for --scanner_max_wait_ms
......................................................................
[tserver] validator for --scanner_max_wait_ms
This patch adds a group validator for the --scanner_max_wait_ms vs
--raft_heartbeat_interval_ms flag's value. As of now, the validator
outputs warning if --scanner_max_wait_ms is set too low compared
with --raft_heartbeat_interval_ms. In addition, --scanner_max_wait_ms
is now tagged as 'runtime' to reflect its de facto behavior.
I also did a minor clean-up of the related code.
I didn't add any test, but I verified that the warning is output upon
kudu-tserver's startup as intended when --scanner_max_wait_ms is set too
low compared with current setting for --raft_heartbeat_interval_ms.
Change-Id: I1dec4173a9ae50a4de34b909283c5a2ee4ef9166
---
M src/kudu/consensus/time_manager.cc
M src/kudu/tserver/tablet_service.cc
2 files changed, 64 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/16655/2
--
To view, visit http://gerrit.cloudera.org:8080/16655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1dec4173a9ae50a4de34b909283c5a2ee4ef9166
Gerrit-Change-Number: 16655
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
