Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16655 )
Change subject: [tserver] validator for --scanner_max_wait_ms ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/16655/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/16655/2/src/kudu/tserver/tablet_service.cc@204 PS2, Line 204: at least up to $2 nit: "to at least $2", otherwise this may read as though the user should increase by an additional heartbeat interval. http://gerrit.cloudera.org:8080/#/c/16655/2/src/kudu/tserver/tablet_service.cc@210 PS2, Line 210: return true; Is this to say that it's not actually that critical an issue? Will snapshot scans with the latest timestamp _mostly_ pass even if improperly set? My concern is that a warning is indeed not severe enough to spur action on the operator, though I do understand why a soft validation is desirable, assuming the service runs ok in a lot of cases even if improperly set. -- To view, visit http://gerrit.cloudera.org:8080/16655 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dec4173a9ae50a4de34b909283c5a2ee4ef9166 Gerrit-Change-Number: 16655 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 27 Oct 2020 06:29:27 +0000 Gerrit-HasComments: Yes
