Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16661 )
Change subject: KUDU-1563. Add an UPDATE_IGNORE and DELETE_IGNORE operations ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/16661/2/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: http://gerrit.cloudera.org:8080/#/c/16661/2/src/kudu/integration-tests/fuzz-itest.cc@1013 PS2, Line 1013: An > nit: A Done http://gerrit.cloudera.org:8080/#/c/16661/2/src/kudu/tablet/tablet-test-base.h File src/kudu/tablet/tablet-test-base.h: http://gerrit.cloudera.org:8080/#/c/16661/2/src/kudu/tablet/tablet-test-base.h@412 PS2, Line 412: > nit: spacing Done http://gerrit.cloudera.org:8080/#/c/16661/2/src/kudu/tablet/tablet-test.cc File src/kudu/tablet/tablet-test.cc: http://gerrit.cloudera.org:8080/#/c/16661/2/src/kudu/tablet/tablet-test.cc@808 PS2, Line 808: same > nit: drop, here and below Done http://gerrit.cloudera.org:8080/#/c/16661/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/16661/2/src/kudu/tablet/tablet.cc@870 PS2, Line 870: } : } > Don't we need to SetFailed() here? I'm surprised no tests failed because of I guess the only type of failure exercised is `IsNotFound`. -- To view, visit http://gerrit.cloudera.org:8080/16661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11dfd06e8d4d22cf1097fe1ff01a1b97cafaf899 Gerrit-Change-Number: 16661 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 27 Oct 2020 20:03:16 +0000 Gerrit-HasComments: Yes
