Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16661 )
Change subject: KUDU-1563. Add an UPDATE_IGNORE and DELETE_IGNORE operations ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/tablet/ops/write_op.cc File src/kudu/tablet/ops/write_op.cc: http://gerrit.cloudera.org:8080/#/c/16661/4/src/kudu/tablet/ops/write_op.cc@105 PS4, Line 105: case RowOperationsPB::INSERT: : InsertIfNotPresent(privileges, WritePrivilegeType::INSERT); : break; : case RowOperationsPB::UPSERT: : InsertIfNotPresent(privileges, WritePrivilegeType::INSERT); : InsertIfNotPresent(privileges, WritePrivilegeType::UPDATE); : break; : case RowOperationsPB::UPDATE: : InsertIfNotPresent(privileges, WritePrivilegeType::UPDATE); : break; : case RowOperationsPB::DELETE: : InsertIfNotPresent(privileges, WritePrivilegeType::DELETE); : break; > Good catch. I will do an audit for other missed locations of RowOperationsP I audited the code for any more missing RowOperationsPB usage. Found another test I can enhance, should be good now. -- To view, visit http://gerrit.cloudera.org:8080/16661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11dfd06e8d4d22cf1097fe1ff01a1b97cafaf899 Gerrit-Change-Number: 16661 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 27 Oct 2020 22:39:00 +0000 Gerrit-HasComments: Yes
