Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16596 )
Change subject: WIP [partitioning] KUDU-2671: Support for range specific HashSchemas. ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/16596/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16596/3//COMMIT_MSG@25 PS3, Line 25: deisgn nit: design http://gerrit.cloudera.org:8080/#/c/16596/3/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/16596/3/src/kudu/common/partition.h@363 PS3, Line 363: c nit: spacing http://gerrit.cloudera.org:8080/#/c/16596/3/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/16596/3/src/kudu/common/partition.cc@387 PS3, Line 387: if (!split_rows.empty() && !range_hash_schema.empty()) { Can we also enforce that 'range_hash_schema' and 'range_bounds' are the same length? Is that always going to be true if 'range_hash_schema' isn't empty? http://gerrit.cloudera.org:8080/#/c/16596/3/src/kudu/common/partition.cc@409 PS3, Line 409: RETURN_NOT_OK(EncodeRangeBounds(range_bounds, schema, &bounds)); : RETURN_NOT_OK(EncodeRangeSplits(split_rows, schema, &splits)); : RETURN_NOT_OK(SplitRangeBounds(schema, std::move(splits), &bounds)); You mentioned that we sort the bounds here, and in your commit message, you mention that being an issue since the 'range_hash_schema' doesn't get sorted in the same order. IMO we should address that in this patch. Could you also add some tests for this? http://gerrit.cloudera.org:8080/#/c/16596/3/src/kudu/common/partition.cc@414 PS3, Line 414: as per current design. nit: remove this -- "current design" doesn't really mean anything in the broader context of the Kudu codebase. -- To view, visit http://gerrit.cloudera.org:8080/16596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8725f4bd072a81b05b36dfc7df0c074c172b4ce8 Gerrit-Change-Number: 16596 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 29 Oct 2020 19:34:10 +0000 Gerrit-HasComments: Yes
