Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16596 )
Change subject: WIP [partitioning] KUDU-2671: Support for range specific HashSchemas. ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/16596/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16596/3//COMMIT_MSG@25 PS3, Line 25: rg/c/1 > nit: design Done http://gerrit.cloudera.org:8080/#/c/16596/3/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/16596/3/src/kudu/common/partition.h@363 PS3, Line 363: o > nit: spacing Done http://gerrit.cloudera.org:8080/#/c/16596/3/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/16596/3/src/kudu/common/partition.cc@387 PS3, Line 387: } > Can we also enforce that 'range_hash_schema' and 'range_bounds' are the sam I check if they are the same length below underneath on line 416. If 'range_hash_schema' isnt empty, then yes its length should match 'range_bounds'. So either 'range_hash_schema' is empty or its length will match 'range_bounds'. http://gerrit.cloudera.org:8080/#/c/16596/3/src/kudu/common/partition.cc@409 PS3, Line 409: if (!InsertIfNotPresent(&range_column_idxs, column_idx)) { : return Status::InvalidArgument("duplicate column in range partition", : schema.column(column_idx).name()) > You mentioned that we sort the bounds here, and in your commit message, you Sure, for now I just changed the existing test to insert them out of order and verify that the final partitions are still in sorted order. I can add a separate test that adds the bounds out of order than checks the partitions. http://gerrit.cloudera.org:8080/#/c/16596/3/src/kudu/common/partition.cc@414 PS3, Line 414: > nit: remove this -- "current design" doesn't really mean anything in the br Done -- To view, visit http://gerrit.cloudera.org:8080/16596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8725f4bd072a81b05b36dfc7df0c074c172b4ce8 Gerrit-Change-Number: 16596 Gerrit-PatchSet: 4 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 19 Nov 2020 05:41:35 +0000 Gerrit-HasComments: Yes
