Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16657 )
Change subject: KUDU-3210 Add option to enforce FIPS approved mode ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/16657/6/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: http://gerrit.cloudera.org:8080/#/c/16657/6/src/kudu/security/openssl_util.cc@196 PS6, Line 196: int num_locks = CRYPTO_num_locks(); : CHECK(!kCryptoLocks); > Yep: that's some extra work, but I guess it's worth it once we started eval Done http://gerrit.cloudera.org:8080/#/c/16657/6/src/kudu/security/openssl_util.cc@198 PS6, Line 198: kCryptoLocks = new Mutex[num_locks]; : > One more note: I think it's totally OK to add such a test in a separate cha Yea I think I'll add it in a follow-up patch, there's something weird with ASSERT_DEATH and the mini cluster. I'll figure that out later. -- To view, visit http://gerrit.cloudera.org:8080/16657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98a6a8b3330ea0b372b188690fadd4d312d8bf93 Gerrit-Change-Number: 16657 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 30 Oct 2020 16:47:03 +0000 Gerrit-HasComments: Yes
