Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16657 )
Change subject: KUDU-3210 Add option to enforce FIPS approved mode ...................................................................... Patch Set 11: (1 comment) > Patch Set 11: Code-Review+1 > > (1 comment) > > Overall looks good, the only question left is about clearing errors which > might left from a Kudu application that initialized openssl but didn't clear > the error stack as needed (say, didn't do proper error handling of openssl > errors). Not sure I understand, are you referring to the comment you just added? http://gerrit.cloudera.org:8080/#/c/16657/11/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: http://gerrit.cloudera.org:8080/#/c/16657/11/src/kudu/security/openssl_util.cc@160 PS11, Line 160: // In case the user's thread has left some error around, clear it. : ERR_clear_error(); : SCOPED_OPENSSL_NO_PENDING_ERRORS; > I didn't notice that in the previous review round, but it seems the previou Done -- To view, visit http://gerrit.cloudera.org:8080/16657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98a6a8b3330ea0b372b188690fadd4d312d8bf93 Gerrit-Change-Number: 16657 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 30 Oct 2020 19:34:41 +0000 Gerrit-HasComments: Yes
