Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16674 )
Change subject: KUDU-1644 hash-partition based in-list predicate optimization ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/16674/8/src/kudu/common/partial_row.h File src/kudu/common/partial_row.h: http://gerrit.cloudera.org:8080/#/c/16674/8/src/kudu/common/partial_row.h@642 PS8, Line 642: // Runtime version of the generic setter. Sorry I don't understand this comment. Also could you write it as per doxygen format? http://gerrit.cloudera.org:8080/#/c/16674/8/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/16674/8/src/kudu/common/partition.h@267 PS8, Line 267: Parition Typo http://gerrit.cloudera.org:8080/#/c/16674/8/src/kudu/common/partition.h@266 PS8, Line 266: // Set is_hash_partition to true if col_name is one of hash partition schema. : void IsSingleColumnHashParition(const Schema& schema, : const std::string& col_name, : bool* is_hash_partition) const { It'd be better to return bool instead of using as an out parameter. http://gerrit.cloudera.org:8080/#/c/16674/8/src/kudu/common/scan_spec.h File src/kudu/common/scan_spec.h: http://gerrit.cloudera.org:8080/#/c/16674/8/src/kudu/common/scan_spec.h@62 PS8, Line 62: empty. is empty http://gerrit.cloudera.org:8080/#/c/16674/8/src/kudu/common/scan_spec.h@80 PS8, Line 80: Support hash(onekey). I suppose the comment indicates, "supports hash schema with only one key"? -- To view, visit http://gerrit.cloudera.org:8080/16674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I202001535669a72de7fbb9e766dbc27db48e0aa2 Gerrit-Change-Number: 16674 Gerrit-PatchSet: 8 Gerrit-Owner: wangning <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: wangning <[email protected]> Gerrit-Comment-Date: Mon, 02 Nov 2020 23:50:17 +0000 Gerrit-HasComments: Yes
