wangning has posted comments on this change. ( http://gerrit.cloudera.org:8080/16674 )
Change subject: KUDU-1644 hash-partition based in-list predicate optimization ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/16674/8/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/16674/8/src/kudu/tserver/tablet_service.cc@2667 PS8, Line 2667: : spec.OptimizeScan(tablet_schema, scanner->arena(), true); : VLOG(3) << "After > If we pushed the emptiness check into CanShortCircuit(), would that avoid t That seems bit different, it seems not good to detect can shortcircuit here. It will return wrong answer and result in the failure of TabletServerTest.TestNonPositiveLimitsShortCircuit / I will split them and re-patch -- To view, visit http://gerrit.cloudera.org:8080/16674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I202001535669a72de7fbb9e766dbc27db48e0aa2 Gerrit-Change-Number: 16674 Gerrit-PatchSet: 14 Gerrit-Owner: wangning <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: wangning <[email protected]> Gerrit-Comment-Date: Tue, 03 Nov 2020 10:24:25 +0000 Gerrit-HasComments: Yes
