Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16658 )
Change subject: KUDU-3210 Increase key size in tests and EMC ...................................................................... Patch Set 12: Code-Review+1 (4 comments) Overall looks good to me, a few nits. http://gerrit.cloudera.org:8080/#/c/16658/12/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/16658/12/src/kudu/mini-cluster/external_mini_cluster.cc@1011 PS12, Line 1011: are nit: are not ? Or that was a part of an incomplete sentence? http://gerrit.cloudera.org:8080/#/c/16658/12/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/16658/12/src/kudu/util/test_util.cc@119 PS12, Line 119: // Some OS distros set the default security level higher than 0, so it's : // necessary to override it to use the key length specified above (which are : // considered lax and don't work in case of security level 2 or higher). nit: do you mind moving this to precede the line with openssl_security_level_override setting, so it's follows the same notation as other documented flags? http://gerrit.cloudera.org:8080/#/c/16658/12/src/kudu/util/test_util.cc@129 PS12, Line 129: nit: it seems unnecessary extra indent was added http://gerrit.cloudera.org:8080/#/c/16658/12/src/kudu/util/test_util.cc@133 PS12, Line 133: FLAGS_log_dir = GetTestDataDirectory(); I guess this needs to be set only once, not sure we need to place it under the this 'for ()' cycle. -- To view, visit http://gerrit.cloudera.org:8080/16658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45b96e0b4499ea1d80db5871a529c732ad41220e Gerrit-Change-Number: 16658 Gerrit-PatchSet: 12 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 03 Nov 2020 18:05:12 +0000 Gerrit-HasComments: Yes
