Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16658 )
Change subject: KUDU-3210 Increase key size in tests and EMC ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/16658/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16658/3//COMMIT_MSG@11 PS3, Line 11: This commit removes the test-only key size > The master test, for example, has an assertion that would fail depending on In the meantime I ran the full test suite (without slow tests) serially on a single host, here's the difference: Before (cbdd66a6a97b0baa286530c67d6c204d3a070396): Performance counter stats for 'ctest': 13155631.327516 task-clock (msec) # 2.493 CPUs utilized 31,113,793 context-switches # 0.002 M/sec 2,011,761 cpu-migrations # 0.153 K/sec 108,051,423 page-faults # 0.008 M/sec 26,531,408,698,301 cycles # 2.017 GHz 27,598,427,400,957 instructions # 1.04 insn per cycle 5,460,757,077,779 branches # 415.089 M/sec 135,745,019,971 branch-misses # 2.49% of all branches 5276.523142389 seconds time elapsed After (fd9f2ed172936d351932bd884ae4bc7270323d09): Performance counter stats for 'ctest': 14133059.898799 task-clock (msec) # 2.354 CPUs utilized 31,297,801 context-switches # 0.002 M/sec 2,005,327 cpu-migrations # 0.142 K/sec 108,193,193 page-faults # 0.008 M/sec 28,630,693,494,760 cycles # 2.026 GHz 30,878,714,897,060 instructions # 1.08 insn per cycle 5,628,824,177,225 branches # 398.274 M/sec 137,309,827,516 branch-misses # 2.44% of all branches 6003.471902752 seconds time elapsed The difference is somewhat more significant than I expected, but I think this is still worth it. We normally use dist-test if we run the whole test suite, except before releases. -- To view, visit http://gerrit.cloudera.org:8080/16658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45b96e0b4499ea1d80db5871a529c732ad41220e Gerrit-Change-Number: 16658 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 30 Oct 2020 17:11:42 +0000 Gerrit-HasComments: Yes
