Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16659 )
Change subject: KUDU-3210 Add lock before verifying signature ...................................................................... Patch Set 14: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/16659/8/src/kudu/security/crypto.cc File src/kudu/security/crypto.cc: http://gerrit.cloudera.org:8080/#/c/16659/8/src/kudu/security/crypto.cc@145 PS8, Line 145: #if OPENSSL_VERSION_NUMBER < 0x10100000L : std::unique_lock<OpenSSLMutex> l(mutex); : #endif > Thanks for these benchmarks, Alexey! This does indeed seem concerning. Adde Sure, I'll run it with the new PS14 patch and report back. http://gerrit.cloudera.org:8080/#/c/16659/14/src/kudu/security/openssl_util.h File src/kudu/security/openssl_util.h: http://gerrit.cloudera.org:8080/#/c/16659/14/src/kudu/security/openssl_util.h@214 PS14, Line 214: bool nit: I guess it might be 'const bool'? http://gerrit.cloudera.org:8080/#/c/16659/13/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: http://gerrit.cloudera.org:8080/#/c/16659/13/src/kudu/security/openssl_util.cc@52 PS13, Line 52: in certain OpenSSL versions > I was intentionally vague here to remain flexible. If someone's really curi This sounds reasonable to me, thank you for the explanation. http://gerrit.cloudera.org:8080/#/c/16659/14/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: http://gerrit.cloudera.org:8080/#/c/16659/14/src/kudu/security/openssl_util.cc@371 PS14, Line 371: locking_enabled_ = FLAGS_openssl_defensive_locking; nit: this might be moved into the constructor's initialization list, so 'locking_enabled_' could become a constant member field. -- To view, visit http://gerrit.cloudera.org:8080/16659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifafc7dcf91db910123276b657515e410bb7f6fcd Gerrit-Change-Number: 16659 Gerrit-PatchSet: 14 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 03 Nov 2020 20:23:25 +0000 Gerrit-HasComments: Yes
