Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16659 )
Change subject: KUDU-3210 Add lock before verifying signature ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/16659/8/src/kudu/security/crypto.cc File src/kudu/security/crypto.cc: http://gerrit.cloudera.org:8080/#/c/16659/8/src/kudu/security/crypto.cc@145 PS8, Line 145: #if OPENSSL_VERSION_NUMBER < 0x10100000L : std::unique_lock<std::mutex> l(mutex); : #endif > Sure, I'll run it with the new PS14 patch and report back. OK, I ran the test adding PS16 on top of the custom code of rpc-bench and I got the following results (that's of course when FIPS mode isn't enabled), and no performance degradation is observed: [ RUN ] RpcBench.BenchmarkCalls WARNING: Logging before InitGoogleLogging() is written to STDERR I1103 15:37:10.751255 1756948 rpc-bench.cc:114] Mode: Sync I1103 15:37:10.751333 1756948 rpc-bench.cc:116] Client threads: 16 I1103 15:37:10.751339 1756948 rpc-bench.cc:122] Worker threads: 1 I1103 15:37:10.751343 1756948 rpc-bench.cc:123] Server reactors: 4 I1103 15:37:10.751348 1756948 rpc-bench.cc:124] Encryption: 1 I1103 15:37:10.751354 1756948 rpc-bench.cc:125] ---------------------------------- I1103 15:37:10.751358 1756948 rpc-bench.cc:126] Reqs/sec: 1866.06 I1103 15:37:10.751379 1756948 rpc-bench.cc:127] User CPU per req: 2293.78us I1103 15:37:10.751385 1756948 rpc-bench.cc:128] Sys CPU per req: 838.988us I1103 15:37:10.751390 1756948 rpc-bench.cc:129] Ctx Sw. per req: 20.9922 I1103 15:37:10.751394 1756948 rpc-bench.cc:130] Server reactor load histogram I1103 15:37:10.751399 1756948 rpc-bench.cc:131] Count: 1980 Mean: 3.9702 Percentiles: 0% (min) = 2 25% = 3 50% (med) = 3 75% = 3 95% = 9 99% = 10 99.9% = 11 99.99% = 11 100% (max) = 11 I1103 15:37:10.751428 1756948 rpc-bench.cc:132] Server reactor latency histogram I1103 15:37:10.751432 1756948 rpc-bench.cc:133] Count: 168644 Mean: 30.0412 Percentiles: 0% (min) = 0 25% = 10 50% (med) = 17 75% = 29 95% = 122 99% = 143 99.9% = 168 99.99% = 342 100% (max) = 924 [ OK ] RpcBench.BenchmarkCalls (10061 ms) [ RUN ] RpcBench.BenchmarkCallsAsync I1103 15:37:20.824440 1756948 rpc-bench.cc:114] Mode: Async I1103 15:37:20.824522 1756948 rpc-bench.cc:118] Client reactors: 16 I1103 15:37:20.824529 1756948 rpc-bench.cc:119] Call concurrency: 60 I1103 15:37:20.824537 1756948 rpc-bench.cc:122] Worker threads: 1 I1103 15:37:20.824543 1756948 rpc-bench.cc:123] Server reactors: 4 I1103 15:37:20.824556 1756948 rpc-bench.cc:124] Encryption: 1 I1103 15:37:20.824563 1756948 rpc-bench.cc:125] ---------------------------------- I1103 15:37:20.824569 1756948 rpc-bench.cc:126] Reqs/sec: 1825.84 I1103 15:37:20.824626 1756948 rpc-bench.cc:127] User CPU per req: 2309.42us I1103 15:37:20.824635 1756948 rpc-bench.cc:128] Sys CPU per req: 804.836us I1103 15:37:20.824645 1756948 rpc-bench.cc:129] Ctx Sw. per req: 19.0348 I1103 15:37:20.824653 1756948 rpc-bench.cc:130] Server reactor load histogram I1103 15:37:20.824661 1756948 rpc-bench.cc:131] Count: 1980 Mean: 3.76465 Percentiles: 0% (min) = 1 25% = 2 50% (med) = 3 75% = 4 95% = 9 99% = 10 99.9% = 11 99.99% = 12 100% (max) = 12 I1103 15:37:20.824676 1756948 rpc-bench.cc:132] Server reactor latency histogram I1103 15:37:20.824682 1756948 rpc-bench.cc:133] Count: 164680 Mean: 29.4397 Percentiles: 0% (min) = 0 25% = 10 50% (med) = 17 75% = 28 95% = 118 99% = 141 99.9% = 172 99.99% = 740 100% (max) = 1198 [ OK ] RpcBench.BenchmarkCallsAsync (10079 ms) -- To view, visit http://gerrit.cloudera.org:8080/16659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifafc7dcf91db910123276b657515e410bb7f6fcd Gerrit-Change-Number: 16659 Gerrit-PatchSet: 8 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 03 Nov 2020 23:44:10 +0000 Gerrit-HasComments: Yes
