Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16674 )
Change subject: KUDU-1644 hash-partition based in-list predicate optimization ...................................................................... Patch Set 18: (2 comments) This looks good to me -- just one more question about testing/perf. http://gerrit.cloudera.org:8080/#/c/16674/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16674/18//COMMIT_MSG@16 PS18, Line 16: Before: : To each tablet, time complexity to complete hash-key based in-list query is: : V * LOG(N/R) * N : : After: : Complexity becomes: : V/P * LOG(N/R) * N I'm curious, do you also have numbers, in the same way that you did in the Java-client patch? https://gerrit.cloudera.org/c/14706/ The added benefit of doing this server-side is that we should see the benefit in both the Java and the C++ clients. http://gerrit.cloudera.org:8080/#/c/16674/17/src/kudu/common/scan_spec.cc File src/kudu/common/scan_spec.cc: http://gerrit.cloudera.org:8080/#/c/16674/17/src/kudu/common/scan_spec.cc@323 PS17, Line 323: > This is not required as I think. Ah I see, thanks for explaining! This seems safe, given we dereference lower_bound_key_ below anyway. -- To view, visit http://gerrit.cloudera.org:8080/16674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I202001535669a72de7fbb9e766dbc27db48e0aa2 Gerrit-Change-Number: 16674 Gerrit-PatchSet: 18 Gerrit-Owner: wangning <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: wangning <[email protected]> Gerrit-Comment-Date: Wed, 11 Nov 2020 02:19:04 +0000 Gerrit-HasComments: Yes
