Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16708 )
Change subject: Change list to update include guards ...................................................................... Patch Set 2: > I couldn't figure whether #pragma once is a C++11 feature. To be > sure that we don't break compatibility with older compilers, all > public C++ client headers like kudu/client/hash.h, > columnar_scan_batch.h (mostly client header files without > "-internal.h") shouldn't incorporate this change. +1 Those external-facing API headers are supposed to be C++98 compliant. As for #pragma once, it's a non-standard, but widely supported feature: * https://en.wikipedia.org/wiki/Pragma_once#Portability * https://en.cppreference.com/w/cpp/preprocessor/imp -- To view, visit http://gerrit.cloudera.org:8080/16708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45aee1e9789389c9bf8c0c2080843552cd464237 Gerrit-Change-Number: 16708 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 11 Nov 2020 03:46:20 +0000 Gerrit-HasComments: No
