Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16708 )
Change subject: Change list to update include guards ...................................................................... Patch Set 3: (14 comments) http://gerrit.cloudera.org:8080/#/c/16708/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16708/3//COMMIT_MSG@11 PS3, Line 11: None of the files : under 'gutil' or 'util' have been touched for now since they are exported : files. As I understand, the only exported files in 'util' are: int128.h kudu_export.h monotime.h slice.h status.h And none of files under 'gutil' are exported. http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/callbacks.h File src/kudu/client/callbacks.h: http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/callbacks.h@17 PS3, Line 17: #pragma once Since 'pragma once' isn't a standard feature (even if supported by most contemporary C++ compilers: https://en.wikipedia.org/wiki/Pragma_once#Portability), I think it's better to keep the original include guard here because this file is targeted for external consumption by old c++98 compilers (like gcc 2.95 and other pre-3.4.2 gcc releaes) as well. Overall, a good criteria to determine whether the file is for external consumption is to look for KUDU_EXPORT macro and doxygen-style comments. A better option is to check what header files are involved in 'kudu_client_exported' target from src/kudu/client/CMakefile http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/columnar_scan_batch.h File src/kudu/client/columnar_scan_batch.h: http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/columnar_scan_batch.h@17 PS3, Line 17: #pragma once ditto http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/hash.h File src/kudu/client/hash.h: http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/hash.h@17 PS3, Line 17: #pragma once ditto http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/resource_metrics.h File src/kudu/client/resource_metrics.h: http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/resource_metrics.h@17 PS3, Line 17: #pragma once ditto http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/row_result.h File src/kudu/client/row_result.h: http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/row_result.h@17 PS3, Line 17: #pragma once ditto http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/scan_batch.h@17 PS3, Line 17: #pragma once ditto http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/scan_predicate.h File src/kudu/client/scan_predicate.h: http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/scan_predicate.h@17 PS3, Line 17: #pragma once ditto http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/schema.h@18 PS3, Line 18: #pragma once dito http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/shared_ptr.h File src/kudu/client/shared_ptr.h: http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/shared_ptr.h@18 PS3, Line 18: #pragma once ditto http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/stubs.h File src/kudu/client/stubs.h: http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/stubs.h@17 PS3, Line 17: #pragma once ditto http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/value.h File src/kudu/client/value.h: http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/value.h@17 PS3, Line 17: #pragma once ditto http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/write_op.h File src/kudu/client/write_op.h: http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/client/write_op.h@17 PS3, Line 17: #pragma once ditto http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/common/partial_row.h File src/kudu/common/partial_row.h: http://gerrit.cloudera.org:8080/#/c/16708/3/src/kudu/common/partial_row.h@17 PS3, Line 17: #pragma once ditto -- To view, visit http://gerrit.cloudera.org:8080/16708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45aee1e9789389c9bf8c0c2080843552cd464237 Gerrit-Change-Number: 16708 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 26 Nov 2020 00:53:33 +0000 Gerrit-HasComments: Yes
