Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16709 )
Change subject: [test] fix tablet_copy_client-test not work for multi-thread DownloadBlocks status collect ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/16709/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16709/2//COMMIT_MSG@7 PS2, Line 7: not work Could you be more specific what didn't work there? The expected number of downloaded threads wasn't set to the desired value or the test didn't work outright? http://gerrit.cloudera.org:8080/#/c/16709/2/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: http://gerrit.cloudera.org:8080/#/c/16709/2/src/kudu/tserver/tablet_copy_client.cc@107 PS2, Line 107: tablet_copy_fail_crash_during_download_block nit: if following the same notation as other flags for fault injection, this flag should be named tablet_copy_fault_crash_during_download_block http://gerrit.cloudera.org:8080/#/c/16709/2/src/kudu/tserver/tablet_copy_client.cc@108 PS2, Line 108: "Fraction of the time that DownloadBlock() will fail." nit: add a space after the period http://gerrit.cloudera.org:8080/#/c/16709/2/src/kudu/tserver/tablet_copy_client.cc@787 PS2, Line 787: . nit: drop the period http://gerrit.cloudera.org:8080/#/c/16709/2/src/kudu/tserver/tablet_copy_client.cc@787 PS2, Line 787: Inject nit: Injected -- To view, visit http://gerrit.cloudera.org:8080/16709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bfbe12bf13d0cc274ad266f62c5539f7da791b8 Gerrit-Change-Number: 16709 Gerrit-PatchSet: 2 Gerrit-Owner: wangning <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: wangning <[email protected]> Gerrit-Comment-Date: Thu, 12 Nov 2020 16:22:38 +0000 Gerrit-HasComments: Yes
