wangning has posted comments on this change. ( http://gerrit.cloudera.org:8080/16709 )
Change subject: [tablet_copy_client-test] fix scenario on DownloadBlocks() error reporting ...................................................................... Patch Set 4: (3 comments) Thank you for helping and reviewing. http://gerrit.cloudera.org:8080/#/c/16709/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16709/3//COMMIT_MSG@7 PS3, Line 7: [tablet_copy_client-test] fix scenario on DownloadBlocks() error reporting > In Kudu, we are striving to keep the summary short :) See https://git-scm. Done http://gerrit.cloudera.org:8080/#/c/16709/3//COMMIT_MSG@9 PS3, Line 9: In patch [1] the status reporting of the multi-threaded DownloadBlocks() : was not tested properly. The original test scenario called only : StartCopy(), but DownloadBlocks() was not called. : : This patch moves the corresponding test code into a separate scenario, : targeting testing failure paths in any of the download threa > How about slightly updating this description to become something like below Done http://gerrit.cloudera.org:8080/#/c/16709/3/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: http://gerrit.cloudera.org:8080/#/c/16709/3/src/kudu/tserver/tablet_copy_client.cc@788 PS3, Line 788: Status::IOError("Injected failure on downloading block")); > nit: I think it's worth moving the newly added MAYBE_RETURN_FAILURE after t Done -- To view, visit http://gerrit.cloudera.org:8080/16709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bfbe12bf13d0cc274ad266f62c5539f7da791b8 Gerrit-Change-Number: 16709 Gerrit-PatchSet: 4 Gerrit-Owner: wangning <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: wangning <[email protected]> Gerrit-Comment-Date: Tue, 17 Nov 2020 03:11:21 +0000 Gerrit-HasComments: Yes
