Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16710 )
Change subject: KUDU-2612 C++ client transaction API ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/16710/8/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/16710/8/src/kudu/client/client-test.cc@6732 PS8, Line 6732: // TODO(aserbin): uncomment this when txn lifecycle is properly implemented Since this is an InternalMiniCluster test, would it make sense to call TxnStatusManager::FinalizeCommitTransaction() directly? That way we can at least test the wait=true case. http://gerrit.cloudera.org:8080/#/c/16710/8/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/16710/8/src/kudu/client/client.h@334 PS8, Line 334: class KUDU_EXPORT KuduTransaction : Can you also mention that this is experimental/unstable API, to give us some flexibility to change it in the future? -- To view, visit http://gerrit.cloudera.org:8080/16710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic48233f72873012ea36ff4a05d16c58a0ba9b407 Gerrit-Change-Number: 16710 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 17 Nov 2020 20:23:50 +0000 Gerrit-HasComments: Yes
