Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16710 )
Change subject: WIP KUDU-2612 C++ client transaction API ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/16710/6/src/kudu/client/transaction-internal.cc File src/kudu/client/transaction-internal.cc: http://gerrit.cloudera.org:8080/#/c/16710/6/src/kudu/client/transaction-internal.cc@124 PS6, Line 124: CommitMode mode > nit: I don't feel too strongly about it, but how would you feel about just This is what I started with, and the switched to this enum :) Yes, I think 'bool wait' can be a good approach as well. I guess we'd like to change the signature to just 'bool wait' in the top-level KuduTransaction::Commit() method in client.h as well, right? -- To view, visit http://gerrit.cloudera.org:8080/16710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic48233f72873012ea36ff4a05d16c58a0ba9b407 Gerrit-Change-Number: 16710 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 16 Nov 2020 22:06:16 +0000 Gerrit-HasComments: Yes
