Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16746 )
Change subject: [build] Fix LLVM build on Xcode 12.2 ...................................................................... Patch Set 2: Code-Review+2 (2 comments) I was able to build LLVM with this patch. Hitting some other issues with the Kudu build, but this at least helps get past building thirdparty. http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@290 PS2, Line 290: sanitzer_common nit: sanitizer here too http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@291 PS2, Line 291: github Curious whether you tried disabling COMPILER_RT_HAS_SANITIZER_COMMON? Or would that be too broad a change? -- To view, visit http://gerrit.cloudera.org:8080/16746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17ea2de460aac4142469c95af201b17554c4f751 Gerrit-Change-Number: 16746 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 18 Nov 2020 23:55:28 +0000 Gerrit-HasComments: Yes
