Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16746 )

Change subject: [build] Fix LLVM build on Xcode 12.2
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@287
PS2, Line 287:       # Xcode 12.2 fails to buld the sanitzers and they are not 
needed.
> nit: sanitizers
Done


http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@290
PS2, Line 290: sanitzer_common
> nit: sanitizer here too
Done


http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@290
PS2, Line 290: sanitzer_common
> nit: sanitizer_common ?
Done


http://gerrit.cloudera.org:8080/#/c/16746/2/thirdparty/build-definitions.sh@291
PS2, Line 291: github
> Curious whether you tried disabling COMPILER_RT_HAS_SANITIZER_COMMON? Or wo
That isn't settable, it is set earlier in the LLVM build.



--
To view, visit http://gerrit.cloudera.org:8080/16746
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17ea2de460aac4142469c95af201b17554c4f751
Gerrit-Change-Number: 16746
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Nov 2020 23:58:54 +0000
Gerrit-HasComments: Yes

Reply via email to