Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16768 )
Change subject: [build] Upgrade to LLVM 10.0.1 and IWYU 0.14 ...................................................................... Patch Set 1: (2 comments) Thank you for the update! http://gerrit.cloudera.org:8080/#/c/16768/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16768/1//COMMIT_MSG@10 PS1, Line 10: It also bumps the language level to C++14 and the minimum gcc version : accordingly. Follow on patches will upgrade the system requirements : documentation to drop deprecated OS versions and GCC versions. Consider moving this part into a separate patch. http://gerrit.cloudera.org:8080/#/c/16768/1/CMakeLists.txt File CMakeLists.txt: PS1: Is there a necessary to lump it with the LLVM update? Maybe, move this into a separate patch? -- To view, visit http://gerrit.cloudera.org:8080/16768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c32abe256978158617a4fe3a3c34e9bfd00fb2 Gerrit-Change-Number: 16768 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 23 Nov 2020 04:50:16 +0000 Gerrit-HasComments: Yes
