Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16768 )

Change subject: [thirdparty] Upgrade to LLVM 11 and IWYU 0.15
......................................................................


Patch Set 4:

It seems IWYU isn't yet happy with the result:

>>> Fixing #includes in 
>>> '/home/jenkins-slave/workspace/kudu-master/0/src/kudu/codegen/module_builder.cc'
@@ -29,7 +29,10 @@
 //       for successful run-time operation of the code generator.
 #include <glog/logging.h>
 #include <llvm/ADT/StringMap.h>
+#include <llvm/ADT/StringMapEntry.h>
 #include <llvm/ADT/StringRef.h>
+#include <llvm/ADT/ilist_iterator.h>
+#include <llvm/ADT/iterator.h>
 #include <llvm/ExecutionEngine/ExecutionEngine.h>
 #include <llvm/ExecutionEngine/MCJIT.h> // IWYU pragma: keep
 #include <llvm/IR/Attributes.h>
IWYU would have edited 1 files on your behalf.


--
To view, visit http://gerrit.cloudera.org:8080/16768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c32abe256978158617a4fe3a3c34e9bfd00fb2
Gerrit-Change-Number: 16768
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 04 Dec 2020 19:42:47 +0000
Gerrit-HasComments: No

Reply via email to