Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 )
Change subject: KUDU-3108: fix invalid memory accesses in merge iterator ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16777/3/src/kudu/tablet/diff_scan-test.cc File src/kudu/tablet/diff_scan-test.cc: http://gerrit.cloudera.org:8080/#/c/16777/3/src/kudu/tablet/diff_scan-test.cc@103 PS3, Line 103: opts.snap_to_exclude = snap1; Does it mean that before adding this option the scan wasn't a 'DiffScan' per se? Does it really matter to specify this snapshot here even if was empty (i.e. contained no rows)? Do you mind adding a comment explaining why it's important to add 'snap1' as 'snap_to_exclude'? -- To view, visit http://gerrit.cloudera.org:8080/16777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ec1cd3fd67ec4ea92a55b5b0ce555123748824d Gerrit-Change-Number: 16777 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Lieber-Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 24 Nov 2020 23:31:15 +0000 Gerrit-HasComments: Yes
