Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16777 )
Change subject: KUDU-3108: fix invalid memory accesses in merge iterator ...................................................................... Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/16777/5/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/16777/5/src/kudu/common/generic_iterators.cc@689 PS5, Line 689: auto hotmax_iter = hotmaxes_.find(state); nit: do we always expect state() to be in the 'hotmaxes_' here? If so, does it make sense to add CHECK/DCHECK on hotmax_iter != hotmaxes_.end() ? http://gerrit.cloudera.org:8080/#/c/16777/5/src/kudu/common/generic_iterators.cc@713 PS5, Line 713: hotmaxes_.insert(state); nit: do we expect state to be a unique element in the set? If so, does it make sense to add CHECK/DCHECK() on the result of the insert()? http://gerrit.cloudera.org:8080/#/c/16777/5/src/kudu/common/generic_iterators.cc@755 PS5, Line 755: hotmaxes_.insert(warmest); nit: add CHECK/DCHECK() on the result of this insert? -- To view, visit http://gerrit.cloudera.org:8080/16777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ec1cd3fd67ec4ea92a55b5b0ce555123748824d Gerrit-Change-Number: 16777 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Lieber-Dembo <a...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 25 Nov 2020 03:12:07 +0000 Gerrit-HasComments: Yes
