Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16785 )
Change subject: [thirdparty] Upgrade CMake to 3.19 ...................................................................... Patch Set 1: (2 comments) Haven't built locally yet, but leaving some initial questions http://gerrit.cloudera.org:8080/#/c/16785/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/16785/1/CMakeLists.txt@27 PS1, Line 27: # Print out the CMAKE_OSX_SYSROOT to help debug Apple build issues. : if (CMAKE_OSX_SYSROOT) : message(STATUS "Using CMAKE_OSX_SYSROOT: ${CMAKE_OSX_SYSROOT}") : endif() Should we also print something if this is an apple build but CMAKE_OSX_SYSROOT isn't defined? http://gerrit.cloudera.org:8080/#/c/16785/1/src/kudu/codegen/CMakeLists.txt File src/kudu/codegen/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/16785/1/src/kudu/codegen/CMakeLists.txt@100 PS1, Line 100: --sysroot="${CMAKE_OSX_SYSROOT}") Is this expected to be set by the user? Or does it get set somewhere in the build process? My mac doesn't set it by default at least. -- To view, visit http://gerrit.cloudera.org:8080/16785 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I125448a3057d0c9da8c82f7e29683ef7844b0aa8 Gerrit-Change-Number: 16785 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 25 Nov 2020 22:15:10 +0000 Gerrit-HasComments: Yes
